This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG49843c503684: [clang][Diagnostics] Simplify emitSnippet()
(authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I think this logic is the same (it's a bit tricky to tell, so it's unfortunate
that precommit CI isn't running for this to help validate), so LGTM.
CHANGES SINCE LAST ACTION
tbaeder updated this revision to Diff 524216.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151075/new/
https://reviews.llvm.org/D151075
Files:
clang/lib/Frontend/TextDiagnostic.cpp
Index: clang/lib/Frontend/TextDiagnostic.cpp
tbaeder created this revision.
tbaeder added a reviewer: aaron.ballman.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Don't try to minimize the times we invoke operator<< on the output
stream by
