This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1c765483fd34: [clang][Diagnostics] Use
llvm::raw_ostream::indent() (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
tbaeder updated this revision to Diff 524271.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151078/new/
https://reviews.llvm.org/D151078
Files:
clang/lib/Frontend/TextDiagnostic.cpp
Index: clang/lib/Frontend/TextDiagnostic.cpp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151078/new/
https://reviews.llvm.org/D151078
___
cfe-commits mailing
tbaeder updated this revision to Diff 524253.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151078/new/
https://reviews.llvm.org/D151078
Files:
clang/lib/Frontend/TextDiagnostic.cpp
Index: clang/lib/Frontend/TextDiagnostic.cpp
tbaeder added inline comments.
Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1195-1197
auto indentForLineNumbers = [&] {
-if (MaxLineNoDisplayWidth > 0) {
- OS << ' ';
- for (unsigned I = 0; I != MaxLineNoDisplayWidth; ++I)
-OS << ' ';
- OS << "
aaron.ballman added inline comments.
Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1195-1197
auto indentForLineNumbers = [&] {
-if (MaxLineNoDisplayWidth > 0) {
- OS << ' ';
- for (unsigned I = 0; I != MaxLineNoDisplayWidth; ++I)
-OS << ' ';
-
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, cjdb.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
TIL that this exists.
Repository:
rG LLVM Github Monorepo
