[PATCH] D151094: [clang][wip] Implement P2564 "consteval must propagate up"

2023-05-22 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 524408. cor3ntin marked 9 inline comments as done. cor3ntin added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. - Address Aaron's comments - Track which expressions are immediately escalating to offer better diagnostics

[PATCH] D151094: [clang][wip] Implement P2564 "consteval must propagate up"

2023-05-22 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/include/clang/AST/Decl.h:2391 + + bool isImmediateFunction() const; + Some documentation on the new API would be useful; seems like most calls to `isConsteval()` should be using `isImmediateFunction()` instead?

[PATCH] D151094: [clang][wip] Implement P2564 "consteval must propagate up"

2023-05-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:1695 /// Number of non-inherited bits in FunctionDeclBitfields. enum { NumFunctionDeclBits = 29 }; Need to update this as well. Comment at:

[PATCH] D151094: [clang][wip] Implement P2564 "consteval must propagate up"

2023-05-22 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151094 Files: clang/docs/ReleaseNotes.rst