[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGa806b3f49667: [clang][Diagnostics][NFC] Remove unnecessary StringRef (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151300/new/

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

tbaeder added a comment. In D151300#4367943 , @aaron.ballman wrote: > In D151300#4367939 , @tbaeder wrote: > >> In D151300#4367884 , >> @aaron.ballman wrote: >> >>>

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

aaron.ballman added a comment. In D151300#4367939 , @tbaeder wrote: > In D151300#4367884 , @aaron.ballman > wrote: > >> LGTM, but it's worth noting that `std::string::pop_back()` calls `erase()` >> and there's

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

tbaeder added a comment. In D151300#4367884 , @aaron.ballman wrote: > LGTM, but it's worth noting that `std::string::pop_back()` calls `erase()` > and there's no guarantee that there's not an extra allocation involved as a > result. However, I've not

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but it's worth noting that `std::string::pop_back()` calls `erase()` and there's no guarantee that there's not an extra allocation involved as a result. However, I've not

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

tbaeder updated this revision to Diff 525031. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151300/new/ https://reviews.llvm.org/D151300 Files: clang/lib/Frontend/TextDiagnostic.cpp Index: clang/lib/Frontend/TextDiagnostic.cpp

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

tbaeder created this revision. tbaeder added reviewers: clang, cjdb, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Seems unnecessary to create a `StringRef` here just so we can drop the