[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

MaskRay added a comment. In D151393#4373764 , @smeenai wrote: > I searched for `__clang_call_terminate` in the Clang test directory when I > was working on this diff. Most tests were testing calls to it, not > definitions. There were a couple of tests

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

smeenai added a comment. I searched for `__clang_call_terminate` in the Clang test directory when I was working on this diff. Most tests were testing calls to it, not definitions. There were a couple of tests checking the definition, but they seemed pretty targeted (e.g.

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

MaskRay added a comment. LGTM. Is there an existing test that can merge in the `uwtable` test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151393/new/ https://reviews.llvm.org/D151393 ___ cfe-commits

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f7b51e4ec09: [CodeGen] Make __clang_call_terminate have an unwind table entry (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151393/new/ https://reviews.llvm.org/D151393 ___ cfe-commits mailing list

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Makes sense to me too, but wait for approval by @efriedma Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151393/new/ https://reviews.llvm.org/D151393

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

smeenai updated this revision to Diff 525429. smeenai added a comment. Call SetLLVMFunctionAttributesForDefinition instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151393/new/ https://reviews.llvm.org/D151393 Files:

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

efriedma added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4698 +if (CodeGenOpts.UnwindTables) + fn->setUWTableKind(llvm::UWTableKind(CodeGenOpts.UnwindTables)); + We probably want to call SetLLVMFunctionAttributesForDefinition()

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

smeenai created this revision. smeenai added reviewers: efriedma, jyknight, rnk, MaskRay. Herald added a subscriber: kristof.beyls. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables debuggers