Re: [PATCH] D15217: Clang documentation for UBSan.

2015-12-04 Thread Alexey Samsonov via cfe-commits
samsonov added a comment. Thanks! Addressed the comments. Repository: rL LLVM http://reviews.llvm.org/D15217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15217: Clang documentation for UBSan.

2015-12-04 Thread Alexey Samsonov via cfe-commits
This revision was automatically updated to reflect the committed changes. samsonov marked 5 inline comments as done. Closed by commit rL254733: Clang documentation for UBSan. (authored by samsonov). Changed prior to commit: http://reviews.llvm.org/D15217?vs=41823=41891#toc Repository: rL

Re: [PATCH] D15217: Clang documentation for UBSan.

2015-12-03 Thread Dan Albert via cfe-commits
danalbert added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:128 @@ +127,3 @@ + ``-fsanitize=undefined``. + - ``-fsanitize=integer``: Checks for undefined or suspicious integer + behavior. Suspicious here meaning that it also checks

Re: [PATCH] D15217: Clang documentation for UBSan.

2015-12-03 Thread Sean Silva via cfe-commits
silvas accepted this revision. silvas added a comment. Thanks for working on this! A tiny nit, but otherwise this LGTM. Comment at: docs/UndefinedBehaviorSanitizer.rst:33 @@ +32,3 @@ + +Use ``clang++`` to compile and link your program with ``-fsanitize=undefined`` +flag. Make

Re: [PATCH] D15217: Clang documentation for UBSan.

2015-12-03 Thread Richard Smith via cfe-commits
rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: docs/UndefinedBehaviorSanitizer.rst:128 @@ +127,3 @@ + ``-fsanitize=undefined``. + - ``-fsanitize=integer``: Checks for undefined or suspicious integer + behavior.

Re: [PATCH] D15217: Clang documentation for UBSan.

2015-12-03 Thread Dan Albert via cfe-commits
danalbert added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:128 @@ +127,3 @@ + ``-fsanitize=undefined``. + - ``-fsanitize=integer``: Checks for undefined or suspicious integer + behavior. rsmith wrote: > danalbert wrote: > >