[PATCH] D152207: [HIP] Instruct lld to go through all archives

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1aee32f1c85: [HIP] Instruct lld to go through all archives (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529667. scchan added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529400. scchan added a comment. Removed redundant comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:184 + // pair with the --whole-archive being added previously + LldArgs.push_back("--no-whole-archive"); For complete sentences in comments, capitalize and add a full stop.

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529366. scchan added a comment. added a matching --no-whole-archive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:165 + // --whole-archive flag such that all global symbols would be linked in. + LldArgs.push_back("--whole-archive"); + Though not strictly required, it's usually better to end

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529311. scchan added a comment. fix some formatting issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529061. scchan added a comment. remove ws Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529060. scchan added a comment. Updated patch to address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files:

[PATCH] D152207: [HIP] Instruct lld to go through all archives

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:168 + // the linker to go through every library to look for kernel functions + LldArgs.push_back("--whole-archive"); auto TargetID = Args.getLastArgValue(options::OPT_mcpu_EQ);

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan created this revision. Herald added a subscriber: yaxunl. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Add the --whole-archive flag when linking HIP programs to instruct lld to go