Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL256822: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics. (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D15223?vs=43885=43969#toc Repository: rL

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

labrinea updated the summary for this revision. labrinea updated this revision to Diff 43885. labrinea added a comment. Disabled optimizers. http://reviews.llvm.org/D15223 Files: test/CodeGen/aarch64-v8.1a-neon-intrinsics.c test/CodeGen/arm-v8.1a-neon-intrinsics.c Index:

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM, and thanks for all of the iteration. -eric http://reviews.llvm.org/D15223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

labrinea added a comment. Hi Eric, The main optimization I feel is useful is mem2reg. Without that, if I want to properly check the right values go to the right operands of the intrinsic calls I have to write FileCheck matchers that match stores and their relevant loads, plus bitcasts. This

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo added a comment. I understand the conflicting priorities here for sure. You'd like a test that's as minimal as possible, without having to depend on external (to clang) libraries here. I really would appreciate it if you'd make the test not rely on mem2reg etc so we can be sure that

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

On Mon, Dec 14, 2015 at 11:05 AM Tim Northover wrote: > > I don't think it's going to be even vaguely that bad here and that you're > > blowing it a bit out of proportion. [...] It does make the tests a > little harder > > to write, but having done a bunch of them it's

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

On 14 December 2015 at 11:12, Eric Christopher wrote: > There really is a pretty good separation of concerns and for a lot if not > most of the tests here all the difference is checking is the arguments, > keeping track of an alloca and making sure that goes is pretty simple

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

Fwiw, I am certainly in Tim'a camp here! Writing a test for that output is doable, and if that's what people want then that's what we'll do. But it's certainly not nice or readable ! On Mon, 14 Dec 2015 at 19:25, Tim Northover via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 14 December

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

> I don't think it's going to be even vaguely that bad here and that you're > blowing it a bit out of proportion. [...] It does make the tests a little > harder > to write, but having done a bunch of them it's not that bad. I've also tried to write such tests in the past, and I did find it that

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

On 14 December 2015 at 09:20, Eric Christopher via cfe-commits wrote: > I understand the conflicting priorities here for sure. You'd like a test > that's as minimal as possible, without having to depend on external (to > clang) libraries here. I really would

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

On Mon, Dec 14, 2015 at 10:44 AM Tim Northover wrote: > On 14 December 2015 at 09:20, Eric Christopher via cfe-commits > wrote: > > I understand the conflicting priorities here for sure. You'd like a test > that's as minimal as possible,

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

jmolloy resigned from this revision. jmolloy removed a reviewer: jmolloy. jmolloy added a comment. Eric is reviewing this; resigning myself. http://reviews.llvm.org/D15223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics. echristo added a comment. One inline comment, thanks! -eric Comment at: test/CodeGen/aarch64-v8.1a-neon-intrinsics.c:4 @@ -3,4 +3,3 @@ // RUN: %clang_cc1 -triple aarch64-linux-gnu -target-feature +neon \ -// RUN

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo added a comment. Should be pretty easy to either use CHECK-DAG or pick out the particular instructions you want to check here. Otherwise you're just checking how the optimizer runs. That, in particular, also sounds like a good backend check. http://reviews.llvm.org/D15223

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

labrinea added inline comments. Comment at: test/CodeGen/aarch64-v8.1a-neon-intrinsics.c:4 @@ -3,4 +3,3 @@ // RUN: %clang_cc1 -triple aarch64-linux-gnu -target-feature +neon \ -// RUN: -target-feature +v8.1a -O3 -S -o - %s \ -// RUN: | FileCheck %s --check-prefix=CHECK

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

labrinea updated this revision to Diff 42035. labrinea added a comment. ASM tests have been removed. http://reviews.llvm.org/D15223 Files: test/CodeGen/aarch64-v8.1a-neon-intrinsics.c test/CodeGen/arm-v8.1a-neon-intrinsics.c Index: test/CodeGen/arm-v8.1a-neon-intrinsics.c

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo added a comment. One inline comment, thanks! -eric Comment at: test/CodeGen/aarch64-v8.1a-neon-intrinsics.c:4 @@ -3,4 +3,3 @@ // RUN: %clang_cc1 -triple aarch64-linux-gnu -target-feature +neon \ -// RUN: -target-feature +v8.1a -O3 -S -o - %s \ -// RUN: | FileCheck

[PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

labrinea created this revision. labrinea added reviewers: jmolloy, rengolin, echristo, cfe-commits. Herald added subscribers: rengolin, aemerson. Existing tests are currently testing generated backend assembly. We want to test the generated frontend IR as well. As discussed on the list we would

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo added a comment. Please remove the asm tests here. As I stated in the original review thread there's no reason for them to be here. Thanks. -eric http://reviews.llvm.org/D15223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org