[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked 2 inline comments as done. Closed by commit rGf4cf51c99c74: [clang][CFG] Add support for partitioning CFG into intervals. (authored by ymandel).

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152263/new/ https://reviews.llvm.org/D152263 ___ cfe-commits mailing list

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/IntervalPartition.cpp:26 + + std::queue Worklist; + for (const CFGBlock *S : Header.succs()) xazax.hun wrote: > ymandel wrote: > > xazax.hun wrote: > > > Is

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel updated this revision to Diff 535002. ymandel added a comment. Respond to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152263/new/ https://reviews.llvm.org/D152263 Files:

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/IntervalPartition.cpp:26 + + std::queue Worklist; + for (const CFGBlock *S : Header.succs()) ymandel wrote: >

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel marked 2 inline comments as not done. ymandel added inline comments. Comment at: clang/lib/Analysis/IntervalPartition.cpp:26 + + std::queue Worklist; + for (const CFGBlock *S : Header.succs()) xazax.hun wrote: > Is it possible we end up adding the same

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel updated this revision to Diff 533641. ymandel marked 2 inline comments as done. ymandel added a comment. responded to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152263/new/ https://reviews.llvm.org/D152263 Files:

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:35 + + std::set Blocks; + Nit: I wonder if we want something like `llvm::DenseSet` when we use smaller types like pointers. Same for `Successors`.

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel updated this revision to Diff 531702. ymandel added a comment. Expand comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152263/new/ https://reviews.llvm.org/D152263 Files: clang/include/clang/Analysis/Analyses/IntervalPartition.h

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:22 + +struct CFGInterval { + CFGInterval(const CFGBlock *Header) : Header(Header), Blocks({Header}) {} A concise definition of what is an interval with a

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel updated this revision to Diff 528845. ymandel added a comment. fix formatting in header file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152263/new/ https://reviews.llvm.org/D152263 Files:

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Adds support for the classic dataflow algorithm that partitions a flow graph into