[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

ymandel marked 3 inline comments as done. ymandel added a comment. In D152732#4415168 , @mboehme wrote: > In D152732#4414707 , @ymandel wrote: > >> In D152732#4414661 ,

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

mboehme added a comment. In D152732#4414707 , @ymandel wrote: > In D152732#4414661 , @xazax.hun > wrote: > >> Huge +1, I think most solvers need to have some resource limits in place as >> the runtime can

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/WatchedLiteralsSolver.h:37 + // measurements like CPU cycles or time to ensure deterministic results. + std::int64_t MaxIterations = std::numeric_limits::max(); +

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb639ebaa8f83: [clang][dataflow] Support limits on the SAT solver to force timeouts. (authored by ymandel). Repository: rG LLVM Github Monorepo

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

ymandel added a comment. In D152732#4414771 , @xazax.hun wrote: > In D152732#4414707 , @ymandel wrote: > >> Ultimately what matters for a user is the global limit. > > I am not 100% sure about that. While it is

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

xazax.hun added a comment. In D152732#4414707 , @ymandel wrote: > Ultimately what matters for a user is the global limit. I am not 100% sure about that. While it is true that the user cares about the process not hanging, but global vs local limits can

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

kinu added a comment. LGTM as well, I was initially thinking about having a local limit per query (which could be easier to pinpoint the particular query that explodes), but per-solver instance limit could make sense as a starter too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

ymandel added a comment. In D152732#4414661 , @xazax.hun wrote: > Huge +1, I think most solvers need to have some resource limits in place as > the runtime can explode. I am just not 100% what is the best approach here, > putting a global limit on the

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Huge +1, I think most solvers need to have some resource limits in place as the runtime can explode. I am just not 100% what is the best approach here, putting a global limit on the

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

ymandel created this revision. ymandel added reviewers: kinu, xazax.hun, mboehme, sgatev. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch allows the client of a