[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

2023-07-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D152818#4457013 , @zahiraam wrote: > In D152818#4456872 , @aaron.ballman > wrote: > >> In D152818#4456797 , @zahiraam >> wrote: >> >>>

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

2023-06-28 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. In D152818#4456872 , @aaron.ballman wrote: > In D152818#4456797 , @zahiraam > wrote: > >> In D152818#4456717 , >> @aaron.ballman wrote: >>

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

2023-06-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D152818#4456797 , @zahiraam wrote: > In D152818#4456717 , @aaron.ballman > wrote: > >> In D152818#4456510 , @zahiraam >> wrote: >> >>>

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

2023-06-28 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. In D152818#4456717 , @aaron.ballman wrote: > In D152818#4456510 , @zahiraam > wrote: > >> In D152818#4456483 , >> @nicolerabjohn wrote: >>

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

2023-06-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D152818#4456510 , @zahiraam wrote: > In D152818#4456483 , @nicolerabjohn > wrote: > >> In D152818#4442116 , @rjmccall >> wrote: >> >>>

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

2023-06-28 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. In D152818#4456483 , @nicolerabjohn wrote: > In D152818#4442116 , @rjmccall > wrote: > >> Does https://reviews.llvm.org/D143241 solve the original problem here, or is >> there

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

2023-06-28 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn added a comment. In D152818#4442116 , @rjmccall wrote: > Does https://reviews.llvm.org/D143241 solve the original problem here, or is > there something deeper? It does not solve the problem, at least for my test case (linked in

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

2023-06-22 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Does https://reviews.llvm.org/D143241 solve the original problem here, or is there something deeper? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152818/new/ https://reviews.llvm.org/D152818