This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1f7c7d4bdd7b: [clangd] Update symbol collector to use
include-cleaner. (authored by VitaNuo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
VitaNuo updated this revision to Diff 542000.
VitaNuo marked 9 inline comments as done.
VitaNuo added a comment.
Address the latest comment batch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152900/new/
https://reviews.llvm.org/D152900
Files:
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks a lot for bearing with me, let's ship it!
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:91
+const Inclusion , ParsedAST ,
+std::shared_ptr PI) {
VitaNuo updated this revision to Diff 539908.
VitaNuo marked 3 inline comments as done.
VitaNuo added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152900/new/
https://reviews.llvm.org/D152900
Files:
VitaNuo marked 19 inline comments as done.
VitaNuo added a comment.
Thank you!
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:839
+ if (!Headers.empty())
+SymbolProviders.insert({S.ID, Headers[0]});
}
kadircet wrote:
> once we have the
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:85
auto Task = [FIndex(FIndex), Path(Path.str()), Version(Version.str()),
- ASTCtx(std::move(ASTCtx)),
- CanonIncludes(CanonIncludes)]() mutable {
+
VitaNuo added a comment.
Thanks for comments!
Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:40
/// Adds a file-to-string mapping from \p ID to \p CanonicalPath.
void addMapping(FileEntryRef Header, llvm::StringRef CanonicalPath);
VitaNuo updated this revision to Diff 535740.
VitaNuo marked 27 inline comments as done.
VitaNuo added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152900/new/
https://reviews.llvm.org/D152900
Files:
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:846
+void SymbolCollector::setSymbolProviders(
+const Symbol , const llvm::SmallVector Headers)
{
+ if (Opts.CollectIncludePath &&
kadircet wrote:
> what about
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:628
CanonIncludes.addSystemHeadersMapping(Clang->getLangOpts());
- std::unique_ptr IWYUHandler =
- collectIWYUHeaderMaps();
can you also add a FIXME here saying that we
VitaNuo added a comment.
Thanks for the comments!
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:393-395
+const auto *FileEntry = SM.getFileEntryForID(FID);
+for (const auto *Export : PI.getExporters(FileEntry, SM.getFileManager()))
+ return
VitaNuo updated this revision to Diff 532964.
VitaNuo marked 8 inline comments as done.
VitaNuo added a comment.
Herald added a subscriber: javed.absar.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152900/new/
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:393-395
+const auto *FileEntry = SM.getFileEntryForID(FID);
+for (const auto *Export : PI.getExporters(FileEntry, SM.getFileManager()))
+ return
VitaNuo created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
VitaNuo updated this revision to Diff 531275.
VitaNuo added a comment.
VitaNuo updated this revision to Diff 531278.
VitaNuo added a reviewer: kadircet.
VitaNuo published this revision for
14 matches
Mail list logo
