aaron.ballman added a comment.
A few small nits, but mostly looks good. Thank you for this!
Comment at: utils/TableGen/ClangAttrEmitter.cpp:2404
@@ -2407,3 +2403,3 @@
static std::set CustomSubjectSet;
- std::set::iterator I = CustomSubjectSet.find(FnName);
+ const auto I =
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D15313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255042: Use range loops and autos in
utils/TableGen/ClangAttrEmitter.cpp and… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D15313?vs=42192=42197#toc
Repository:
rL
Eugene.Zelenko removed rL LLVM as the repository for this revision.
Eugene.Zelenko updated this revision to Diff 42192.
Eugene.Zelenko added a comment.
Replaced const auto with auto as suggested by Aaron.
http://reviews.llvm.org/D15313
Files:
utils/TableGen/ClangAttrEmitter.cpp
Index:
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I fixed Clang-tidy modernize-loop-convert and modernize-use-auto. Autos are
also used for
