[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

2023-06-20 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbca11bafba97: [clang-format] Add InsertNewlineAtEOF to .clang-format files (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153208/new/

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

2023-06-19 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D153208#4433511 , @HazardyKnusperkeks wrote: > In D153208#4431697 , @owenpan wrote: > >> In D153208#4431239 , >> @HazardyKnusperkeks wrote:

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

2023-06-19 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D153208#4431697 , @owenpan wrote: > In D153208#4431239 , > @HazardyKnusperkeks wrote: > >> We also could add a clang-format style, the you wouldn't have to to touch >> all

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

2023-06-19 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D153208#4431239 , @HazardyKnusperkeks wrote: > We also could add a clang-format style, the you wouldn't have to to touch all > .clang-format files. ;) Something like `BasedOnStyle: clang-format`? I like it but feel that it

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

2023-06-18 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. We also could add a clang-format style, the you wouldn't have to to touch all .clang-format files. ;) CHANGES SINCE LAST ACTION

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

2023-06-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 532434. owenpan edited the summary of this revision. owenpan added a comment. Took out `Language: Cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153208/new/ https://reviews.llvm.org/D153208 Files: clang/include/clang/Format/.clang-format

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

2023-06-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Also, add `Language: Cpp` to make it explicit. Then reformat all