[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm closed this revision. arsenm added a comment. 9d84f8dc948b3188fdec9a1a080eb6d845c2082d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 accepted this revision. bob80905 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 ___ cfe-commits mailing list

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 534111. arsenm added a comment. Add fixme to test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added a comment. In D153233#4443000 , @bob80905 wrote: > Should there be tests added for usage of scalable vector types for RISC-V / > AArch64? > I typically have added such tests in the past, as shown here: > https://reviews.llvm.org/D135011

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added a comment. Should there be tests added for usage of scalable vector types for RISC-V / AArch64? I typically have added such tests in the past, as shown here: https://reviews.llvm.org/D135011 Also, would you be able to add something at the top of the strictfp file that states

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added a comment. I believe it's also necessary to declare the builtin_elementwise builtins in \clang\include\clang\Basic\Builtins.def. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 ___

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 533789. arsenm added a comment. SemaCXX test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 533779. arsenm added a comment. Rebase on fix for wrong debug name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added inline comments. Comment at: clang/test/CodeGen/strictfp-elementwise-bulitins.cpp:190 +// CHECK-NEXT: entry: +// CHECK-NEXT:[[ELT_TRUNC:%.*]] = tail call <4 x float> @llvm.canonicalize.v4f32(<4 x float> [[A]]) #[[ATTR4]] +// CHECK-NEXT:ret <4 x float>

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added a comment. I'd like to ask, is there a reason why there isn't a test for these new builtins under SemaCXX/builtins_elementwise_math.cpp? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/test/CodeGen/strictfp-elementwise-bulitins.cpp:190 +// CHECK-NEXT: entry: +// CHECK-NEXT:[[ELT_TRUNC:%.*]] = tail call <4 x float> @llvm.canonicalize.v4f32(<4 x float> [[A]]) #[[ATTR4]] +// CHECK-NEXT:ret <4 x float>

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:18583 << Callee << CallerTCB; } } arsenm wrote: > arsenm wrote: > > bob80905 wrote: > > > I don't believe you intended to remove all this code in your latest > > >

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:18583 << Callee << CallerTCB; } } arsenm wrote: > bob80905 wrote: > > I don't believe you intended to remove all this code in your latest update, > > did you? > I

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 533007. arsenm marked an inline comment as done. arsenm added a comment. Keep fixing documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added inline comments. Comment at: clang/test/CodeGen/strictfp-elementwise-bulitins.cpp:13-14 +// CHECK-NEXT:[[ADD:%.*]] = tail call <2 x float> @llvm.experimental.constrained.fadd.v2f32(<2 x float> [[TMP0]], <2 x float> [[TMP1]], metadata !"round.dynamic", metadata

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 532590. arsenm marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

sepavloff added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm created this revision. arsenm added reviewers: aaron.ballman, RKSimon, fhahn, junaire, bob80905, python3kgae, erichkeane, sepavloff, kpn, andrew.w.kaylor. Herald added a subscriber: StephenFan. Herald added a project: All. arsenm requested review of this revision. Herald added a