[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd937836ead34: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements (authored by tomasz-kaminski-sonarsource). Repository:

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153273/new/ https://reviews.llvm.org/D153273 ___ cfe-commits mailing

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

tomasz-kaminski-sonarsource marked 2 inline comments as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/nonreturn-destructors-cfg-output.cpp:99 +// +// CHECK: [B2 (NORETURN)] +// CHECK-NEXT:1: [B3.3].~A() (Implicit destructor)

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/lifetime-cfg-output.cpp:760 // CHECK-NEXT:2: [B1.1]++ -// CHECK-NEXT:3: [B2.2] (Lifetime ends) -// CHECK-NEXT:4: [B3.1]

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

xazax.hun added inline comments. Comment at: clang/test/Analysis/lifetime-cfg-output.cpp:760 // CHECK-NEXT:2: [B1.1]++ -// CHECK-NEXT:3: [B2.2] (Lifetime ends) -// CHECK-NEXT:4: [B3.1] (Lifetime ends) +// CHECK-NEXT:3: [B2.4] (Lifetime ends) +// CHECK-NEXT:

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

tomasz-kaminski-sonarsource updated this revision to Diff 539529. tomasz-kaminski-sonarsource marked 5 inline comments as done. tomasz-kaminski-sonarsource added a comment. Switched to ranges when applicable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:1936-1938 +for (LocalScope::const_iterator I = DstPos; I != BasePos; ++I) + if (I.pointsToFirstDeclaredVar()) +appendScopeBegin(Block, *I, S); steakhal

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

steakhal added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:1819-1826 + for (std::size_t idx = 1, count = LocalScopeEndMarkers.size(); idx < count; + ++idx) { +LocalScope::const_iterator B = LocalScopeEndMarkers[idx]; +LocalScope::const_iterator E =

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

tomasz-kaminski-sonarsource updated this revision to Diff 539470. tomasz-kaminski-sonarsource marked 3 inline comments as done. tomasz-kaminski-sonarsource added a comment. Apply review suggestion and replaced make_scope_exit with SaveAndRestore that was already used in file. Repository: rG

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:773 void addLoopExit(const Stmt *LoopStmt); - void addAutomaticObjDtors(LocalScope::const_iterator B, -LocalScope::const_iterator E, Stmt *S); -

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

ymandel added a comment. In D153273#4471672 , @steakhal wrote: > I'd appreciate some review on this, given that a lot of you would be affected > by the changes of CFG. > By changes I mean, fixes for goto statements, properly calling destructors > and

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'd appreciate some review on this, given that a lot of you would be affected by the changes of CFG. By changes I mean, fixes for goto statements, properly calling destructors and stuff.