shafik added inline comments.
Comment at: clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp:293
+ e = {E::E1};
+ e = {0}; // expected-error {{cannot initialize a value of type 'E' with an
rvalue of type 'int'}}
+}
rsmith wrote:
> This looks valid to me.
rsmith requested changes to this revision.
rsmith added inline comments.
This revision now requires changes to proceed.
Comment at: clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp:293
+ e = {E::E1};
+ e = {0}; // expected-error {{cannot initialize a value of type 'E'
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:15441-15443
// C++11 5.17p9:
// The meaning of x = {v} [...] is that of x = T(v) [...]. The meaning
// of x = {} is x = T().
The code change doesn't match this comment,
shafik updated this revision to Diff 536451.
shafik marked an inline comment as done.
shafik added a comment.
- Added release note
- Added test case
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153375/new/
https://reviews.llvm.org/D153375
Files:
clang/docs/ReleaseNotes.rst
cor3ntin accepted this revision.
cor3ntin added a comment.
This revision is now accepted and ready to land.
LGTM but can you add a line in Release Notes? Thanks
Comment at: clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp:292
+ E e;
+ e = {0}; // expected-error {{cannot
shafik added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153375/new/
https://reviews.llvm.org/D153375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shafik added a comment.
It looks like the build failure happens on other PR as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153375/new/
https://reviews.llvm.org/D153375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
shafik created this revision.
shafik added reviewers: aaron.ballman, erichkeane, rsmith.
Herald added a project: All.
shafik requested review of this revision.
In `Sema::CreateBuiltinBinOp()` we were incorrectly using direct initialization
instead of copy initialization. This led to a crash in a
