[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 546635. evelez7 added a comment. Reintroduce fix from f4de606ef271 and use clang frontend for C++ tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. FYI, this patch fails the Windows bots in a different way. (you can see the error triggered in the pre-merge build in https://buildkite.com/llvm-project/premerge-checks/builds/161603#018909c4-fe90-4de6-91a3-d251dc5ada8f) The error message from our builders are:

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added a comment. @haowei Thank you for letting me know! That patch does seem to fix it, unfortunately it didn't fail on my end. Thanks again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. Thanks for reverting. I wasn't doing any changes to this when you were asking though, but looking at build log, it looks like the assertion error disappeared after f4de606ef271fe362f03d30c53a850f9877ec238

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added a comment. In D153557#4554980 , @haowei wrote: > Hi, we are seeing a test error on `Clang :: > ExtractAPI/constructor_destructor.cpp` after this patch was landed. Error > message: Hi! Sorry about that, I see you've made some changes. Do

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. Hi, we are seeing a test error on `Clang :: ExtractAPI/constructor_destructor.cpp` after this patch was landed. Error message: Script: -- : 'RUN: at line 1'; rm -rf /b/s/w/ir/x/w/llvm_build/tools/clang/test/ExtractAPI/Output/constructor_destructor.cpp.tmp :

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b76b44e46ac: [clang][ExtractAPI] Add support for C++ classes (authored by evelez7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 ___

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 546323. evelez7 added a comment. Add test for overloaded operator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:770 +template <> +struct has_function_signature : public std::true_type {}; + dang wrote: > Does `CXXInstanceMethodRecord` need one of these as well? `CXXInstanceMethodRecord`

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 546317. evelez7 marked 4 inline comments as done. evelez7 added a comment. Address review feedback, add tests, and small refactors. - Add tests for destructors, constructors, and conversion methods. - Remove redundant check-nots in existing tests. - Properly

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

dang added a comment. Looking pretty good, if you can address the last few bits of feedback I am happy to merge this. Comment at: clang/include/clang/ExtractAPI/API.h:770 +template <> +struct has_function_signature : public std::true_type {}; + Does

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added a comment. There aren't any variables or fields in the tests currently, waiting on D154038 because of no semicolons in their fragments. Comment at: clang/lib/ExtractAPI/API.cpp:19 #include "clang/AST/RawCommentList.h"

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 536071. evelez7 added a comment. Add C++ class tests, fix exception spec fragments - Add tests for single and multiple inheritance, class methods, and functions with noexcept. - Exception spec fragments had a space included in it, moved it to separate

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 535559. evelez7 marked 6 inline comments as done. evelez7 added a comment. Address some review feedback Remove RK_Struct, RK_Union from CXXClassRecord::classof, use std::string for AccessControl, style and remove unused imports Repository: rG LLVM

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

dang added a comment. Starting to come together nicely, but I think now would be a good time to write some tests. I am particularly interested in more complex situations like inheritance hierarchies. Comment at: clang/include/clang/ExtractAPI/API.h:25 #include

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 534141. evelez7 added a comment. Add conversion function and overloaded operator support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files:

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 534060. evelez7 added a comment. Fix duplicate visitation of CXXRecordDecls by overloading WalkUpFromCXXRecordDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 533799. evelez7 added a comment. Do not include return types for constructors/destructors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files:

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 533788. evelez7 added a comment. Add access control serialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a subscriber: ChuanqiXu. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add ExtractAPI