This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG989879f8fded: [Clang] Allow C++11 style initialisation of
SVE types. (authored by paulwalker-arm).
Repository:
rG LLVM Github Monorepo
CHANGES
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153560/new/
https://reviews.llvm.org/D153560
paulwalker-arm updated this revision to Diff 534914.
paulwalker-arm added a comment.
Rebased and updated to allow copy initialisation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153560/new/
https://reviews.llvm.org/D153560
Files:
paulwalker-arm added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1878
+
+llvm_unreachable("Unexpected initialization of a scalable vector!");
+ }
efriedma wrote:
> paulwalker-arm wrote:
> > efriedma wrote:
> > > I can see why you can't
efriedma added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1878
+
+llvm_unreachable("Unexpected initialization of a scalable vector!");
+ }
paulwalker-arm wrote:
> efriedma wrote:
> > I can see why you can't have more than one element...
paulwalker-arm added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1878
+
+llvm_unreachable("Unexpected initialization of a scalable vector!");
+ }
efriedma wrote:
> I can see why you can't have more than one element... but both zero and
efriedma added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1878
+
+llvm_unreachable("Unexpected initialization of a scalable vector!");
+ }
I can see why you can't have more than one element... but both zero and one
seem feasible. (For
andrew added a comment.
With this I can build the Arm Compute Library for SVE with clang
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153560/new/
https://reviews.llvm.org/D153560
___
cfe-commits
paulwalker-arm updated this revision to Diff 533631.
paulwalker-arm added a comment.
Renamed test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153560/new/
https://reviews.llvm.org/D153560
Files:
clang/lib/CodeGen/CGExprScalar.cpp
paulwalker-arm updated this revision to Diff 533629.
paulwalker-arm added a comment.
Moved C++ test into CodeGenCXX.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153560/new/
https://reviews.llvm.org/D153560
Files:
paulwalker-arm created this revision.
Herald added a project: All.
paulwalker-arm requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://github.com/llvm/llvm-project/issues/63223
Repository:
rG LLVM Github Monorepo
11 matches
Mail list logo