This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfe5bab537270: [Driver][ARM] Warn about -mabi= for assembler
input (authored by MaskRay).
Changed prior to commit:
michaelplatings accepted this revision.
michaelplatings added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153691/new/
https://reviews.llvm.org/D153691
MaskRay updated this revision to Diff 534668.
MaskRay marked an inline comment as done.
MaskRay added a comment.
Thanks for the comments. Improved comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153691/new/
https://reviews.llvm.org/D153691
michaelplatings added a comment.
The change seems OK to me in principle, but I'd appreciate the code being more
self-descriptive. Thanks.
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:528
+
+// Accept but warn.
+if (Arg *A =
MaskRay created this revision.
MaskRay added reviewers: michaelplatings, peter.smith, simon_tatham,
nathanchance.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: