[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b29b8a2aba2: Expose DataflowAnalysisContext.querySolver(). (authored by bazuzi, committed by gribozavr). Repository: rG LLVM Github Monorepo

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added a comment. Since the timeline for being able to use this is dependent not only on commits but integrates as well, lets go ahead with this then. Can someone commit it for me when we're ready? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

sammccall added a comment. In D153805#4464487 , @bazuzi wrote: > It looks like D153485 changes the context > for the last few comments significantly. What's the appetite for adding yet > another child commit to the

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added a comment. It looks like D153485 changes the context for the last few comments significantly. What's the appetite for adding yet another child commit to the chain D153485 is in that exposes the solver directly?

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

sammccall added a comment. LG as is, sorry for the noise! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:183 + /// been stored in flow conditions. + Solver::Result querySolver(llvm::DenseSet Constraints); + gribozavr2

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:183 + /// been stored in flow conditions. + Solver::Result querySolver(llvm::DenseSet Constraints); +

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:183 + /// been stored in flow conditions. + Solver::Result querySolver(llvm::DenseSet Constraints); + sammccall wrote: > sammccall wrote: > > FWIW,

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:183 + /// been stored in flow conditions. + Solver::Result querySolver(llvm::DenseSet Constraints); + sammccall wrote: > sammccall wrote: > >

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi updated this revision to Diff 536293. bazuzi added a comment. Rebase on main to pull in change from DenseSet to SetVector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153805/new/ https://reviews.llvm.org/D153805 Files:

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

sammccall accepted this revision. sammccall added a comment. Thanks! As discussed offline, I had some concerns about whether there were any cases where it was safe to use formulas separate from the FC that might constrain them. But we found some: these are formulas produced by the downstream

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi updated this revision to Diff 536269. bazuzi added a comment. Updated function comment to remove unnecessary repetition and include newly-discovered caveat re: flow conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153805/new/

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:178-181 + /// Possible outcomes are: + /// - `Satisfiable`: A satisfying assignment

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi created this revision. bazuzi added reviewers: ymandel, gribozavr2, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. bazuzi requested review of this revision. Herald added a project: clang. This allows for use of the same solver used by the DAC for additional solving