[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

steven_wu added a comment. I don't like this doesn't write to the output file by `-o` too. I also think the output should just match `llvm-dis` output, instead of splitting into multiple files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

MaskRay added a comment. Is a simpler change like D154923 sufficient? It also handles the case when we don't emit `.ll`, but `.o` or `.s`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris added a comment. > You can be more specific that multi-module bitcode files are for > -fsanitize=cfi and -fwhole-program-vtables. And it will be more useful to > include an example in the summary. Fixed. > This is a bit odd as the -o file may no longer an output. This could be >

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris added a comment. Thanks! Pushed as 048a0c246908291c82d2f4531d3df45a4c4a8a18 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. > [clang] Allow disassembly of multi-module bitcode files The subject confused me as I did not recognize what disassembly means :) > Clang currently exits with an error message

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

MaskRay added inline comments. Comment at: clang/test/Frontend/split-lto-ir-support.cpp:1 +// RUN: %clang -c -flto=thin %s -o %t0.bc +// RUN: mkdir %t1.d Without -fsanitize=cfi or -fwhole-program-vtables, -fsplit-lto-unit is not the default. You need to specify

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris updated this revision to Diff 538867. ormris added a comment. Attempt to fix pre-merge checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906 Files: clang/include/clang/CodeGen/CodeGenAction.h clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris added a comment. Yes, I'm working on a new test that's less target dependent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906 ___ cfe-commits mailing

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

aaron.ballman added a comment. FWIW, the precommit CI Windows bot found an issue with the newly added test case. Maybe test the Itanium and MS ABIs separately? (Uncertain if an Itanium-only test is appropriate but that's another option.) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris updated this revision to Diff 535202. ormris added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906 Files: clang/include/clang/CodeGen/CodeGenAction.h

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris created this revision. ormris added reviewers: efriedma, rjmccall, MaskRay, aaron.ballman. Herald added subscribers: steven_wu, hiraditya. Herald added a project: All. ormris requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang