[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

MaskRay abandoned this revision. MaskRay added a comment. Obsoleted by D154125 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154043/new/ https://reviews.llvm.org/D154043

[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

MaskRay added a comment. In D154043#4459446 , @simon_tatham wrote: > The details of this approach look good to me, but is this the best place to > solve it? Doing it in clang means that //every// language front end that > wants to use either of these

[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

efriedma added a comment. I also think it makes sense to fix the alignment when we lower the metadata, not in the frontend, unless I'm missing something. It's not clear to me how "strict-align" is relevant; if sanitizer lowering is generating "align 4" loads, the relevant pointers need to be

[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

simon_tatham added a comment. The details of this approach look good to me, but is this the best place to solve it? Doing it in clang means that //every// language front end that wants to use either of these sanitizers is responsible for doing this same work: tagging every IR function with

[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

MaskRay created this revision. MaskRay added reviewers: efriedma, rjmccall, simon_tatham, samitolvanen. Herald added a subscriber: kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix