[PATCH] D154068: [clangd] Don't show header for namespace decl in Hover

2023-06-29 Thread Haojian Wu via Phabricator via cfe-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG21b6da35f1d5: [clangd] Dont show header for namespace 
decl in Hover (authored by hokein).

Changed prior to commit:
  https://reviews.llvm.org/D154068?vs=535732=535809#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154068/new/

https://reviews.llvm.org/D154068

Files:
  clang-tools-extra/clangd/Hover.cpp
  clang-tools-extra/clangd/unittests/HoverTests.cpp


Index: clang-tools-extra/clangd/unittests/HoverTests.cpp
===
--- clang-tools-extra/clangd/unittests/HoverTests.cpp
+++ clang-tools-extra/clangd/unittests/HoverTests.cpp
@@ -3059,7 +3059,13 @@
   }
   ns::F^oo d;
 )cpp",
-[](HoverInfo ) { HI.Provider = "\"foo.h\""; }}};
+[](HoverInfo ) { HI.Provider = "\"foo.h\""; }},
+{R"cpp(
+  namespace foo {};
+  using namespace fo^o;
+)cpp",
+[](HoverInfo ) { HI.Provider = ""; }},
+};
 
   for (const auto  : Cases) {
 Annotations Code{Case.Code};
Index: clang-tools-extra/clangd/Hover.cpp
===
--- clang-tools-extra/clangd/Hover.cpp
+++ clang-tools-extra/clangd/Hover.cpp
@@ -1374,7 +1374,10 @@
 if (!HI->Value)
   HI->Value = printExprValue(N, AST.getASTContext()).PrintedValue;
 maybeAddCalleeArgInfo(N, *HI, PP);
-maybeAddSymbolProviders(AST, *HI, include_cleaner::Symbol{*DeclToUse});
+
+if (!isa(DeclToUse))
+  maybeAddSymbolProviders(AST, *HI,
+  include_cleaner::Symbol{*DeclToUse});
   } else if (const Expr *E = N->ASTNode.get()) {
 HoverCountMetric.record(1, "expr");
 HI = getHoverContents(N, E, AST, PP, Index);


Index: clang-tools-extra/clangd/unittests/HoverTests.cpp
===
--- clang-tools-extra/clangd/unittests/HoverTests.cpp
+++ clang-tools-extra/clangd/unittests/HoverTests.cpp
@@ -3059,7 +3059,13 @@
   }
   ns::F^oo d;
 )cpp",
-[](HoverInfo ) { HI.Provider = "\"foo.h\""; }}};
+[](HoverInfo ) { HI.Provider = "\"foo.h\""; }},
+{R"cpp(
+  namespace foo {};
+  using namespace fo^o;
+)cpp",
+[](HoverInfo ) { HI.Provider = ""; }},
+};
 
   for (const auto  : Cases) {
 Annotations Code{Case.Code};
Index: clang-tools-extra/clangd/Hover.cpp
===
--- clang-tools-extra/clangd/Hover.cpp
+++ clang-tools-extra/clangd/Hover.cpp
@@ -1374,7 +1374,10 @@
 if (!HI->Value)
   HI->Value = printExprValue(N, AST.getASTContext()).PrintedValue;
 maybeAddCalleeArgInfo(N, *HI, PP);
-maybeAddSymbolProviders(AST, *HI, include_cleaner::Symbol{*DeclToUse});
+
+if (!isa(DeclToUse))
+  maybeAddSymbolProviders(AST, *HI,
+  include_cleaner::Symbol{*DeclToUse});
   } else if (const Expr *E = N->ASTNode.get()) {
 HoverCountMetric.record(1, "expr");
 HI = getHoverContents(N, E, AST, PP, Index);
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154068: [clangd] Don't show header for namespace decl in Hover

2023-06-29 Thread Viktoriia Bakalova via Phabricator via cfe-commits 
VitaNuo accepted this revision.
VitaNuo added a comment.
This revision is now accepted and ready to land.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154068/new/

https://reviews.llvm.org/D154068

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154068: [clangd] Don't show header for namespace decl in Hover

2023-06-29 Thread Haojian Wu via Phabricator via cfe-commits 
hokein created this revision.
hokein added a reviewer: VitaNuo.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

The header for namespace symbol is barely useful.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154068

Files:
  clang-tools-extra/clangd/Hover.cpp
  clang-tools-extra/clangd/unittests/HoverTests.cpp


Index: clang-tools-extra/clangd/unittests/HoverTests.cpp
===
--- clang-tools-extra/clangd/unittests/HoverTests.cpp
+++ clang-tools-extra/clangd/unittests/HoverTests.cpp
@@ -3059,7 +3059,13 @@
   }
   ns::F^oo d;
 )cpp",
-[](HoverInfo ) { HI.Provider = "\"foo.h\""; }}};
+[](HoverInfo ) { HI.Provider = "\"foo.h\""; }},
+{R"cpp(
+  namespace foo {};
+  using namespace fo^o;
+)cpp",
+[](HoverInfo ) { HI.Provider = ""; }},
+};
 
   for (const auto  : Cases) {
 Annotations Code{Case.Code};
Index: clang-tools-extra/clangd/Hover.cpp
===
--- clang-tools-extra/clangd/Hover.cpp
+++ clang-tools-extra/clangd/Hover.cpp
@@ -1374,7 +1374,10 @@
 if (!HI->Value)
   HI->Value = printExprValue(N, AST.getASTContext()).PrintedValue;
 maybeAddCalleeArgInfo(N, *HI, PP);
-maybeAddSymbolProviders(AST, *HI, include_cleaner::Symbol{*DeclToUse});
+
+if (!isa(DeclToUse))
+  maybeAddSymbolProviders(AST, *HI,
+  include_cleaner::Symbol{*DeclToUse});
   } else if (const Expr *E = N->ASTNode.get()) {
 HoverCountMetric.record(1, "expr");
 HI = getHoverContents(N, E, AST, PP, Index);


Index: clang-tools-extra/clangd/unittests/HoverTests.cpp
===
--- clang-tools-extra/clangd/unittests/HoverTests.cpp
+++ clang-tools-extra/clangd/unittests/HoverTests.cpp
@@ -3059,7 +3059,13 @@
   }
   ns::F^oo d;
 )cpp",
-[](HoverInfo ) { HI.Provider = "\"foo.h\""; }}};
+[](HoverInfo ) { HI.Provider = "\"foo.h\""; }},
+{R"cpp(
+  namespace foo {};
+  using namespace fo^o;
+)cpp",
+[](HoverInfo ) { HI.Provider = ""; }},
+};
 
   for (const auto  : Cases) {
 Annotations Code{Case.Code};
Index: clang-tools-extra/clangd/Hover.cpp
===
--- clang-tools-extra/clangd/Hover.cpp
+++ clang-tools-extra/clangd/Hover.cpp
@@ -1374,7 +1374,10 @@
 if (!HI->Value)
   HI->Value = printExprValue(N, AST.getASTContext()).PrintedValue;
 maybeAddCalleeArgInfo(N, *HI, PP);
-maybeAddSymbolProviders(AST, *HI, include_cleaner::Symbol{*DeclToUse});
+
+if (!isa(DeclToUse))
+  maybeAddSymbolProviders(AST, *HI,
+  include_cleaner::Symbol{*DeclToUse});
   } else if (const Expr *E = N->ASTNode.get()) {
 HoverCountMetric.record(1, "expr");
 HI = getHoverContents(N, E, AST, PP, Index);
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits