[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

scchan added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:47 + * - ``__amdgcn_feature___`` + - Defined for each supported target feature. The value is 1 if the feature is enabled and 0 if it is disabled. Allowed feature names are sramecc and xnack. + * -

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:47 + * - ``__amdgcn_feature___`` + - Defined for each supported target feature. The value is 1 if the feature is enabled and 0 if it is disabled. Allowed

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

scchan added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:47 + * - ``__amdgcn_feature___`` + - Defined for each supported target feature. The value is 1 if the feature is enabled and 0 if it is disabled. Allowed feature names are sramecc and xnack. + * -

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG051cb7c1f57d: [amdgpu] start documenting amdgpu support by clang (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Need to start somewhere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 ___ cfe-commits

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl updated this revision to Diff 536887. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 Files: clang/docs/AMDGPUSupport.rst Index:

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + lamb-j wrote: > arsenm wrote: > > "on amdgpu target" doesn't sound grammatical > "for

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

lamb-j added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + arsenm wrote: > "on amdgpu target" doesn't sound grammatical "for the //amdgpu// target"? or "on AMD GPU targets?"

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

arsenm added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + "on amdgpu target" doesn't sound grammatical CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl updated this revision to Diff 536203. yaxunl added a comment. added `__AMDGCN_WAVEFRONT_SIZE__` and reordered CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 Files: clang/docs/AMDGPUSupport.rst Index: clang/docs/AMDGPUSupport.rst

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl added a comment. In D154133#4462387 , @jdoerfert wrote: > I would recommend to introduce `__AMDGCN_WAVEFRONT_SIZE__` as an alias for > `'__AMDGCN_WAVEFRONT_SIZE` and at some point to deprecate the latter. > Otherwise, LGTM Added

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

jdoerfert added a comment. I would recommend to introduce `__AMDGCN_WAVEFRONT_SIZE__` as an alias for `'__AMDGCN_WAVEFRONT_SIZE` and at some point to deprecate the latter. Otherwise, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl updated this revision to Diff 536004. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 Files: clang/docs/AMDGPUSupport.rst Index:

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:33 + * - ``__AMD__`` + - Indicates that the code is being compiled for an AMD GPU. + * - ``__AMDGPU__`` jdoerfert wrote: > FWIW, this arguably

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:62 + - Defined if fast FMA instruction is available. + * - ``__AMDGCN_WAVEFRONT_SIZE`` + - Defines the wavefront size. Allowed values are 32 and 64. jdoerfert wrote: > Any reason

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

arsenm added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:54 + - Defined if FMAF instruction is available (deprecated). + * - ``FP_FAST_FMAF`` + - Defined if fast FMAF instruction is available. The fma macro was actually from the opencl

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

jdoerfert added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:33 + * - ``__AMD__`` + - Indicates that the code is being compiled for an AMD GPU. + * - ``__AMDGPU__`` FWIW, this arguably confusing use of __AMD__, and duplication of __AMDGPU__,

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl updated this revision to Diff 535952. yaxunl added a comment. remove redundant text CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 Files: clang/docs/AMDGPUSupport.rst Index: clang/docs/AMDGPUSupport.rst

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl created this revision. yaxunl added reviewers: b-sumner, arsenm, tra, scchan. Herald added subscribers: kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added subscribers: jplehr, sstefan1, wdng. Herald added a