tbaeder added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16893
+
+ if (const StringLiteral *SL = dyn_cast(Message);
+ SL && SL->getCharByteWidth() == 1) {
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16898
+ }
+
+
cor3ntin updated this revision to Diff 538154.
cor3ntin added a comment.
Rebase.
This is now ready for review.
Note that after discussion with CWG, the consensus seems to be that the wording
is fine, an implementation has to behave
As if the full expression Message.data()[I] is called for each
cor3ntin added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:16384
+ Expr *SizeExpression,
+ Expr *PtrExpression, ASTContext ,
+ EvalResult ) const {
cor3ntin updated this revision to Diff 536571.
cor3ntin added a comment.
Make EvaluateCharPointerAsString parameters const.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154290/new/
https://reviews.llvm.org/D154290
Files:
cor3ntin updated this revision to Diff 536570.
cor3ntin edited the summary of this revision.
cor3ntin added a comment.
Add feature test macro and complete ODRDiagsEmitter change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154290/new/
tbaeder added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:16384
+ Expr *SizeExpression,
+ Expr *PtrExpression, ASTContext ,
+ EvalResult ) const {
cor3ntin created this revision.
Herald added a subscriber: arphaman.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
...data are evaluated in the same
evaluation context and that cleanup occurs once
