This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf653d14065a3: [clang][dataflow] Various refactorings to
UncheckedOptionalAccessModel. (authored by mboehme).
Repository:
rG LLVM Github Monorepo
mboehme added a comment.
libcxx and clangd failures look unrelated
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154597/new/
https://reviews.llvm.org/D154597
___
cfe-commits mailing list
ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.
Nice! I don't think you need a second review for this one, since it's just
superficial (if important!) refactoring.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
mboehme added inline comments.
Comment at:
clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:258
/// symbolic value of its "has_value" property.
-StructValue (Environment , BoolValue ) {
+StructValue (BoolValue , Environment ) {
auto = Env.create();
mboehme created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
mboehme requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
These are intended to ease an upcoming change
