Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

beanz updated this revision to Diff 42891. beanz added a comment. Cleaning up the python helper as per Sean's suggestions. http://reviews.llvm.org/D15462 Files: CMakeLists.txt utils/perf-training/CMakeLists.txt utils/perf-training/README.txt utils/perf-training/cxx/hello_world.cpp

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

silvas added a comment. Thanks. This LGTM but I'd wait for Duncan or Justin to sign off on it; they're likely to have more higher-level thoughts. Comment at: utils/perf-training/perf-helper.py:36 @@ +35,3 @@ + cmd.extend(findProfrawFiles(args[2])) +

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

Sean Silva writes: > silvas added a comment. > > Thanks. This LGTM but I'd wait for Duncan or Justin to sign off on it; > they're likely to have more higher-level thoughts. I'm fine with the concept and Sean's LGTM should cover the details :) > > >

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

This revision was automatically updated to reflect the committed changes. Closed by commit rL255740: [CMake] Add support for generating profdata for clang from training files (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D15462?vs=42891=42943#toc Repository: rL

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

beanz added a comment. Sean, The reason for restricting to Unix is two fold. (1) the shell script goop, which I can replace with python and (2) I don't have a windows box to test on, so I didn't want people to think it worked. If I replace the shell goop with Python this will probably "Just

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

beanz updated this revision to Diff 42761. beanz added a comment. Updates based on feedback from Sean and Vedant. - Should work on Windows now - Cleaned up lit config code http://reviews.llvm.org/D15462 Files: CMakeLists.txt utils/perf-training/CMakeLists.txt

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

silvas added a comment. In http://reviews.llvm.org/D15462#309889, @beanz wrote: > Sean, > > The reason for restricting to Unix is two fold. (1) the shell script goop, > which I can replace with python and (2) I don't have a windows box to test > on, so I didn't want people to think it worked.

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

silvas added a comment. Can you elaborate on why this patch is restricted to unix? Also, this probably requires some documentation in http://llvm.org/docs/CMake.html (we don't really have an analogous page just for clang currently, so the llvm one is probably the best place right now)

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

vsk added a comment. Thanks! Interesting approach. I think @cmatthews would appreciate a `generate-profdata-from-lnt` target if you're up for it :). Comments inline -- Comment at: utils/perf-training/CMakeLists.txt:2 @@ +1,3 @@ +if(LLVM_BUILD_INSTRUMENTED AND NOT WIN32) + if

[PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

beanz created this revision. beanz added reviewers: dexonsmith, silvas, friss, vsk, bogner, cmatthews. beanz added a subscriber: cfe-commits. This patch adds support for using LIT to drive generating PGO profile data for clang. This first pass implementation should work on Linux and Unix based