[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

lodato added a comment. Oh, and I meant to start with: I'm so sorry for the extremely long delay. I was swamped with work before then I forgot about this. Please know that I appreciate your effort here and that I didn't mean to blow you off. Best regards, Mark Repository: rL LLVM

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

lodato added a comment. I think the simplest solution to those problems is to require `--diff`. An alternative is to write the changes directly to the index without touching the working directory, but that would require some flag because the behavior is unintuitive, and the implementation

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev added a comment. Mark, just wanted to check if the review is still somewhere on your radar. Repository: rL LLVM https://reviews.llvm.org/D15465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev added a comment. Hi @lodato, thanks mate. Repository: rL LLVM https://reviews.llvm.org/D15465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

lodato added a comment. Sorry, I have been very busy with other work so I haven't had a chance to follow along. (I don't work on LLVM team - I just contributed this script.) I'll try to carve out some time to review within the next week. Repository: rL LLVM https://reviews.llvm.org/D15465

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

nevion added a comment. I'm paying attention at least. I updated your patch prior to your posting and temporarily made due with it. I'm pretty nervous that I will lose work with my commit style and the lingering issue. Based on what I've seen so far I can't use the git hooks and so I want

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev added a comment. Did anybody have a chance to review it and/or try it out? Repository: rL LLVM https://reviews.llvm.org/D15465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev updated this revision to Diff 112801. Alexander-Shukaev added a comment. Alright, so you got me excited about this task once again. Now, I've just rebased to the latest `git-clang-format` and it has changed a bit. Nevertheless, I've updated the previous patch accordingly and

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

nevion added a comment. Can anyone inform me why these don't work on clang-format-diff? Repository: rL LLVM https://reviews.llvm.org/D15465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev added a comment. Man, I have to admit it's really a shame that I didn't find time to work on this further but I'm truly too busy these days. However, I believe the primary point why I didn't have motivation to do this is because the flaw that was pointed out actually never

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

nevion added a comment. Hi - I'm coming here from Alexander's post on stackoverflow and I'm interested to see both how this solution is progressing (no replies for 1.5

Re: [PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

lodato added inline comments. Comment at: git-clang-format:124 @@ -121,3 +123,3 @@ del opts.quiet commit, files = interpret_args(opts.args, dash_dash, opts.commit) lodato wrote: > This will work without `--diff` (otherwise it will try to apply changes in

Re: [PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

lodato added a subscriber: lodato. lodato requested changes to this revision. lodato added a reviewer: lodato. lodato added a comment. This revision now requires changes to proceed. This does not work properly because it calls `clang-format` on the files in the working directory, even if