[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

Hahnfeld added a comment. Ok, turns out I had old test binaries around that got automatically picked up by `lit`. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154856/new/ https://reviews.llvm.org/D154856

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

tejohnson added a comment. In D154856#4494195 , @Hahnfeld wrote: > Hi @tejohnson, I'm seeing crashes after this revision: > > Failed Tests (2): > LLVM-Unit :: Passes/./PluginsTests/0/2 > LLVM-Unit :: Passes/./PluginsTests/1/2 I haven't seen

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

Hahnfeld added a comment. Hi @tejohnson, I'm seeing crashes after this revision: Failed Tests (2): LLVM-Unit :: Passes/./PluginsTests/0/2 LLVM-Unit :: Passes/./PluginsTests/1/2 A stack trace looks as follows: #0 0x7fba1f899667 llvm::sys::PrintStackTrace(llvm::raw_ostream&,

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

jplehr added a comment. The preparation patch (https://reviews.llvm.org/D154872) caused the AMD GPU OpenMP buildbot to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154856/new/ https://reviews.llvm.org/D154856

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4a82b62258c: [MemProf] Use new option/pass for profile feedback and matching (authored by tejohnson). Repository: rG LLVM Github Monorepo

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

snehasish accepted this revision. snehasish added a comment. This revision is now accepted and ready to land. lgtm, thanks for testing the various combinations of profiles passed to each option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

tejohnson updated this revision to Diff 538805. tejohnson added a comment. Rebase on D154872 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154856/new/ https://reviews.llvm.org/D154856 Files:

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

tejohnson added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemProfiler.cpp:912 +const TargetLibraryInfo = FAM.getResult(F); +readMemprof(M, F, MemProfReader.get(), TLI); + } tejohnson wrote: > snehasish wrote: > > I think we can

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

tejohnson added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemProfiler.cpp:912 +const TargetLibraryInfo = FAM.getResult(F); +readMemprof(M, F, MemProfReader.get(), TLI); + } snehasish wrote: > I think we can we split this patch

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

snehasish added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemProfiler.cpp:912 +const TargetLibraryInfo = FAM.getResult(F); +readMemprof(M, F, MemProfReader.get(), TLI); + } I think we can we split this patch into two to make the

[PATCH] D154856: [MemProf] Use new option/pass for profile feedback and matching

tejohnson created this revision. tejohnson added reviewers: snehasish, davidxl. Herald added subscribers: wlei, Enna1, ormris, wenlei, steven_wu, hiraditya. Herald added a project: All. tejohnson requested review of this revision. Herald added a subscriber: MaskRay. Herald added projects: clang,