[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6ae740e743a: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage (authored by t-rasmud). Herald added a project: clang.

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

t-rasmud updated this revision to Diff 544547. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154880/new/ https://reviews.llvm.org/D154880 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! I'm excited to learn what this new facility discovers! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1730-1735 +#ifndef NDEBUG +#define DEBUG_NOTE_DECL_FAIL(D, Msg)

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

t-rasmud updated this revision to Diff 544521. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154880/new/ https://reviews.llvm.org/D154880 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1730-1731 +#define DEBUG_NOTE_DECL_FAIL(D, Msg) \ +Handler.addDebugNoteForVar((D), (D)->getBeginLoc(), "failed to produce fixit for declaration '" + D->getNameAsString() + "'" + Msg) +

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

t-rasmud added a comment. In D154880#4533035 , @ziqingluo-90 wrote: > This is a lot of work, thank you @t-rasmud & @NoQ ! > > I have a minor suggestion: can we use some macros to make the debug stub even > shorter? > The prefix `"failed to produce

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

t-rasmud updated this revision to Diff 544510. t-rasmud retitled this revision from "[-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage." to "[-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.". CHANGES SINCE LAST ACTION