[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D155078#4494167 , @ldionne wrote: > In D155078#4493995 , @aaron.ballman > wrote: > >> In D155078#4493468 , @ldionne >> wrote: >> >>>

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. Thanks for working on this! I really like the direction. I mainly skimmed the code since the patch as already landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Louis Dionne via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG298f207e0649: [ci] Make libc++ and Clang CI scripts independent (authored by ldionne). Changed prior to commit:

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. I will land this because I can tell this is correct after following the CI pipeline's execution, and https://github.com/google/llvm-premerge-checks/pull/452 has already landed so the CI could start becoming red anytime now. If there are concerns about Clang having its

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. In D155078#4493995 , @aaron.ballman wrote: > In D155078#4493468 , @ldionne wrote: > >> Ok, this is ready to go. More context around this change: >> >> I created a clang-specific CI

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D155078#4493468 , @ldionne wrote: > Ok, this is ready to go. More context around this change: > > I created a clang-specific CI pipeline > (https://buildkite.com/llvm-project/clang-ci) and Clang CI jobs will now >

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. See https://github.com/google/llvm-premerge-checks/pull/452 for the other side of this change. https://github.com/google/llvm-premerge-checks/pull/452 must land after this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Nikolas Klauser via Phabricator via cfe-commits
philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. I like this a lot! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 539553. ldionne added a comment. Poke CI after fixing Clang CI pipeline clone URL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 Files:

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. Ok, this is ready to go. More context around this change: I created a clang-specific CI pipeline (https://buildkite.com/llvm-project/clang-ci) and Clang CI jobs will now trigger inside that pipeline instead of inside the libc++ pipeline

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 539534. ldionne added a comment. Poke CI after fixing pipeline settings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 Files:

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

2023-07-12 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 539526. ldionne added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Touch a file inside Clang to test the triggering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION