yaxunl updated this revision to Diff 544812.
yaxunl marked an inline comment as done.
yaxunl added a reviewer: Anastasia.
yaxunl added a comment.
revised by comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155213/new/
https://reviews.llvm.org/D155213
Files:
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:2391
if (TargetDecl->hasAttr()) {
if (getLangOpts().OpenCLVersion <= 120) {
scchan wrote:
> The block here needs to be aware of this new
scchan added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:2391
if (TargetDecl->hasAttr()) {
if (getLangOpts().OpenCLVersion <= 120) {
The block here needs to be aware of this new flag.
CHANGES SINCE LAST ACTION
yaxunl updated this revision to Diff 544491.
yaxunl edited the summary of this revision.
yaxunl added a comment.
make the option generic for offloading languages
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155213/new/
https://reviews.llvm.org/D155213
Files:
jdoerfert added a comment.
This should be named -foffload*, it should not use HIP in the description, and
it should apply to OpenMP as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155213/new/
https://reviews.llvm.org/D155213
___
yaxunl added a comment.
ping
I renamed the option as `-fno-offload-uniform-block`. I switched to `offload`
instead of `gpu` because I think in the long run offloading toolchains are not
limited to GPUs, therefore sooner or later we will feel `-fgpu-` options are
awkward. I did not use
yaxunl updated this revision to Diff 544345.
yaxunl retitled this revision from "[HIP] Add `-fno-hip-uniform-block`" to
"[HIP] Add `-fno-offload-uniform-block`".
yaxunl edited the summary of this revision.
yaxunl added a comment.
rename the option
CHANGES SINCE LAST ACTION
