tbaeder closed this revision.
tbaeder marked an inline comment as done.
tbaeder added a comment.
Also forgot the link in the commit message here. This is closed by
https://github.com/llvm/llvm-project/commit/6ba4b213346fad36634a5571feda4f4481097c3a
Repository:
rG LLVM Github Monorepo
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:232
+ static_cast((F.classify() & FPClassArg).getZExtValue());
+ S.Stk.push>(Integral<32,
tbaeder marked an inline comment as done.
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:232
+ static_cast((F.classify() & FPClassArg).getZExtValue());
+ S.Stk.push>(Integral<32, true>::from(Result));
+
aaron.ballman
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:225
+ const CallExpr *CE = cast(E);
+ PrimType FPClassArgT = *S.getContext().classify(CE->getArgs()[1]->getType());
+ APSInt FPClassArg = peekToAPSInt(S.Stk, FPClassArgT);
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155393/new/
https://reviews.llvm.org/D155393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155393/new/
https://reviews.llvm.org/D155393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
