xazax.hun added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:201
-/// Models a value of `struct` or `class` type, with a flat map of fields to
-/// child storage locations, containing all accessible members of base struct
-/// and class
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
mboehme marked 3 inline comments as done.
Closed by commit rG44f98d0101fe: [clang][dataflow] Eliminate duplication
between `AggregateStorageLocation` and… (authored by
mboehme marked 4 inline comments as done.
mboehme added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:201
-/// Models a value of `struct` or `class` type, with a flat map of fields to
-/// child storage locations, containing all accessible
xazax.hun accepted this revision.
xazax.hun added a comment.
I did not do a thorough review checking every line, but I read the design paper
and skimmed through this patch. Love the direction, and I am OK with landing
this as is.
Comment at:
mboehme marked an inline comment as done.
mboehme added a comment.
CI failures look unrelated:
- Windows failure is in SemaCXX/static-assert-cxx26.cpp. I can't see a way in
which this patch should affect the failure of this test (the dataflow framework
isn't used in Clang itself)
-
mboehme marked 3 inline comments as done.
mboehme added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:466
+ return;
+Env.setStorageLocationStrict(*S, *MemberLoc);
}
ymandel wrote:
> This diff makes me very happy. :)
Me
mboehme updated this revision to Diff 542337.
mboehme marked 11 inline comments as done.
mboehme added a comment.
Changes in response to review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155446/new/
https://reviews.llvm.org/D155446
ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.
This is really impressive. Thank you!
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:337-338
+ /// Returns the location of the result
mboehme marked 16 inline comments as done.
mboehme added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:337-338
+ /// Returns the location of the result object that a prvalue `E` of record
+ /// type initializes.
+ ///
mboehme updated this revision to Diff 541980.
mboehme added a comment.
Various changes in response to review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155446/new/
https://reviews.llvm.org/D155446
Files:
ymandel added a comment.
I got up to Transfer.cpp and figured I should send along what I have. Looks
very good so far! I should have the rest of the review in a few hours...
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:337-338
+ /// Returns
mboehme updated this revision to Diff 541021.
mboehme added a comment.
Added bugfix for `refreshStructValue()` as a diffbase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155446/new/
https://reviews.llvm.org/D155446
Files:
mboehme created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
mboehme requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
After this change, `StructValue` is just a
13 matches
Mail list logo
