This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG378fcbf20ff8: [clang][Interp] Handle CXXNoexceptExprs
(authored by tbaeder).
Changed prior to commit:
cor3ntin accepted this revision.
cor3ntin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155707/new/
https://reviews.llvm.org/D155707
___
cfe-commits mailing list
tbaeder updated this revision to Diff 543266.
tbaeder added a comment.
Always ignore the operand expression.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155707/new/
https://reviews.llvm.org/D155707
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
tbaeder marked an inline comment as done.
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1203
+ if (DiscardResult)
+return this->discard(Operand);
+ return this->emitConstBool(E->getValue(), E);
Looks like this is
tbaeder marked an inline comment as done.
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:1037-1045
+namespace NE {
+ constexpr int foo() noexcept {
+return 1;
+ }
+ static_assert(noexcept(foo()), "");
+ constexpr int foo2() {
+return 1;
tbaeder updated this revision to Diff 543265.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155707/new/
https://reviews.llvm.org/D155707
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
clang/test/AST/Interp/literals.cpp
cor3ntin added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:1037-1045
+namespace NE {
+ constexpr int foo() noexcept {
+return 1;
+ }
+ static_assert(noexcept(foo()), "");
+ constexpr int foo2() {
+return 1;
Can you either add
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
