This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2dea969d8337: [clang][CodeGen] Introduce
`-frecord-command-line` for MachO (authored by antoniofrighetto).
Repository:
rG LLVM Github Monorepo
sgraenitz accepted this revision.
sgraenitz added a comment.
This revision is now accepted and ready to land.
Great! This LGTM. Let's keep the review open for a few days and see if there is
more feedback.
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1424
antoniofrighetto added a comment.
Thanks a lot for the reviews and for pointing out clang tests as well, there
was a minor update to do there too!
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1424
+MCSection
antoniofrighetto updated this revision to Diff 542483.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155716/new/
https://reviews.llvm.org/D155716
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Driver/clang_f_opts.c
llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h
sgraenitz added a comment.
That's an excellent patch! I didn't expect it could be so compact. Thanks for
working on this! Please find below 2 inline comments on details.
On July 25th release/17.x will branch away. It would be great to land this
before and have it in the upcoming release.
antoniofrighetto created this revision.
antoniofrighetto added reviewers: davide, ab, scott.linder.
Herald added a subscriber: hiraditya.
Herald added a project: All.
antoniofrighetto requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, MaskRay.
Herald added
