This revision was automatically updated to reflect the committed changes.
Closed by commit rG0cb2906cdfb3: [NFC][clang] Fix static analyzer concerns
(authored by Fznamznon).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155842/new/
Fznamznon updated this revision to Diff 543420.
Fznamznon added a comment.
Rebase to maybe fix precommit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155842/new/
https://reviews.llvm.org/D155842
Files:
clang/lib/Frontend/HeaderIncludeGen.cpp
tahonermann accepted this revision.
tahonermann added a comment.
This is a good change since the default copy constructor would do bad things
when `ownsOutputFile` is true. The copy assignment operator is already
implicitly deleted because of the presence of a data member of reference type,
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155842/new/
https://reviews.llvm.org/D155842
Fznamznon created this revision.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus,
a.sidorin, baloghadamsoftware.
Herald added a project: All.
Fznamznon requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.