[PATCH] D156154: [clang][ConstExprEmitter] handle IntegerLiterals and IntegralCasts

nickdesaulniers updated this revision to Diff 543662. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - put back the IntegralCast, for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156154/new/

[PATCH] D156154: [clang][ConstExprEmitter] handle IntegerLiterals and IntegralCasts

nickdesaulniers added a comment. In D156154#4529265 , @efriedma wrote: > As a practical matter, I'm not sure this helps much; ExprConstant should be > reasonably fast for simple integers. The performance issues only really show > for structs/arrays.

[PATCH] D156154: [clang][ConstExprEmitter] handle IntegerLiterals and IntegralCasts

efriedma added a comment. As a practical matter, I'm not sure this helps much; ExprConstant should be reasonably fast for simple integers. The performance issues only really show for structs/arrays. But maybe it helps a little to handle a few of the most common integer expressions.

[PATCH] D156154: [clang][ConstExprEmitter] handle IntegerLiterals and IntegralCasts

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Improves the ability of ConstExprEmitter to evaluate constants. Found by adding asserts to