[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

2023-09-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. In D156337#4558410 , @aaron.ballman wrote: > Was there an RFC for this extension to the attribute? (There doesn't need to > be one, I'm just wondering if there's more background info on what's driving > this patch

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

2023-08-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Was there an RFC for this extension to the attribute? (There doesn't need to be one, I'm just wondering if there's more background info on what's driving this patch forward and discussion around the design.) I'd like some more details about how this attribute

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

2023-07-28 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 545074. serge-sans-paille added a comment. (rebased on `main`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

2023-07-28 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 545060. serge-sans-paille added a comment. Take reviewers comment into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337 Files: clang/include/clang/Basic/Attr.td

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

2023-07-27 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1906-1908 + if (D.isConstexpr()) +// Note: constexpr already initializes everything correctly. +trivialAutoVarInit = LangOptions::TrivialAutoVarInitKind::Uninitialized; Should we

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

2023-07-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. I think a test verifying that during constant evaluation we still flag the read of a local tagged uninitialized as ill-formed would be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

2023-07-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a reviewer: clang-language-wg. shafik added a comment. Adding clang-language-wg for more visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

2023-07-26 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added reviewers: jfb, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This