[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

zixuan-wu added a comment. Herald added a subscriber: sunshaoce. I am afraid there is also error at clang/test/Driver/as-options.s when default triple is 'riscv32-unknown-elf' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

zixuan-wu added inline comments. Comment at: clang/test/Driver/debug-options.c:245 // // RUN: %clang -### -c -gsplit-dwarf -g -gno-pubnames %s 2>&1 | FileCheck -check-prefix=NOPUB %s // Here should add not or specify the target with x86 because it fails when

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

Hahnfeld added a comment. `test/Driver/openmp-offload-jit.c` was still failing for me with CUDA installed, so I pushed rGcb3136b0d3596f5c3984e4fb49359e2a1a28a547 to add an explicit `--cuda-path` and make it return exit code

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. In D156363#4554884 , @MaskRay wrote: > In D156363#4554812 , @jhuber6 wrote: > >> >> Probably because we're not specifying the `--target=` I'll add that in my >> fix for AMDGPU I'm working

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. In D156363#4554913 , @yaxunl wrote: > Thanks. I will wait for your patch. You can leave the tricky ones to me if > you would like. e.g. the rocm-detect.hip You can go ahead and fix that one then. Repository: rG LLVM Github

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

yaxunl added a comment. In D156363#4554693 , @jhuber6 wrote: > In D156363#4554687 , @yaxunl wrote: > >> In D156363#4554435 , @jhuber6 >> wrote: >> >>> Clang ::

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4554812 , @jhuber6 wrote: > In D156363#4554790 , @ro wrote: > >> In D156363#4553043 , @ro wrote: >> >>> It seems the latest commit of

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. In D156363#4554790 , @ro wrote: > In D156363#4553043 , @ro wrote: > >> It seems the latest commit of this patch has (re-)introduced two failures on >> the Solaris/amd64 buildbot >>

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. In D156363#4553043 , @ro wrote: > It seems the latest commit of this patch has (re-)introduced two failures on > the Solaris/amd64 buildbot > : > > FAIL:

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. In D156363#4554687 , @yaxunl wrote: > In D156363#4554435 , @jhuber6 wrote: > >> Clang :: Driver/amdgpu-hip-system-arch.c >> Clang :: Driver/cuda-bad-arch.cu >> Clang ::

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

yaxunl added a comment. In D156363#4554435 , @jhuber6 wrote: > Clang :: Driver/amdgpu-hip-system-arch.c > Clang :: Driver/cuda-bad-arch.cu > Clang :: Driver/hip-autolink.hip > Clang :: Driver/hip-binding.hip > Clang :: Driver/hip-cuid-hash.hip

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. Pretty sure most of this is `hip` returning an error if it can't find `ROCm`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/ https://reviews.llvm.org/D156363 ___

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. Clang :: Driver/amdgpu-hip-system-arch.c Clang :: Driver/cuda-bad-arch.cu Clang :: Driver/hip-autolink.hip Clang :: Driver/hip-binding.hip Clang :: Driver/hip-cuid-hash.hip Clang :: Driver/hip-cuid.hip Clang :: Driver/hip-default-gpu-arch.hip Clang ::

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. Also seems to have impacted one of the AMDGPU bots but not the other, not sure why https://lab.llvm.org/staging/#/builders/247/builds/4145. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. It seems the latest commit of this patch has (re-)introduced two failures on the Solaris/amd64 buildbot : FAIL: Clang::clang_f_opts.c FAIL: Clang::lto.c I cannot really make sense of that. Repository: rG

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

Hahnfeld added a comment. Hi, after this change I have three failing tests: Failed Tests (3): Clang :: Driver/lto.cu Clang :: Driver/openmp-offload-gpu.c Clang :: Driver/openmp-offload-jit.c I have CUDA installed on my system, not sure if a bot is testing this configuration...

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

abrachet added a comment. > I am curious what @phosek 's failures were about. I created D156792 which should fix those errors, and explains what the errors were. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4546818 , @dyung wrote: > In D156363#4546171 , @dyung wrote: > >> In D156363#4545474 , @MaskRay >> wrote: >> >>> In D156363#4545215

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. In D156363#4546171 , @dyung wrote: > In D156363#4545474 , @MaskRay wrote: > >> In D156363#4545215 , @dyung wrote: >> >>> If you cannot reproduce

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. In D156363#4545474 , @MaskRay wrote: > In D156363#4545215 , @dyung wrote: > >> If you cannot reproduce this issue, I can take my buildbot offline and try >> to reproduce it to pinpoint

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4545215 , @dyung wrote: > If you cannot reproduce this issue, I can take my buildbot offline and try to > reproduce it to pinpoint which command is causing the problem, but I won’t be > able to do so until Monday.

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4545410 , @phosek wrote: > We see 14 failing tests on our Linux and macOS builders, and 6 failing tests > on Windows builders: > > - `Clang :: Driver/csky-toolchain.c` > - `Clang :: Driver/env.c` > - `Clang ::

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

phosek added a comment. We see 14 failing tests on our Linux and macOS builders, and 6 failing tests on Windows builders: - `Clang :: Driver/csky-toolchain.c` - `Clang :: Driver/env.c` - `Clang :: Driver/fsanitize.c` - `Clang :: Driver/gcc-install-dir.cpp` - `Clang :: Driver/gcc-toolchain.cpp`

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. If you cannot reproduce this issue, I can take my buildbot offline and try to reproduce it to pinpoint which command is causing the problem, but I won’t be able to do so until Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. In D156363#4544803 , @aaron.ballman wrote: > In D156363#4544782 , @thakis wrote: > >> http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this >> something on my end? >

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4544803 , @aaron.ballman wrote: > In D156363#4544782 , @thakis wrote: > >> http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this >> something on my end?

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

aaron.ballman added a comment. In D156363#4544782 , @thakis wrote: > http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this > something on my end? Nope, this same failure is happening in our build farm:

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

thakis added a comment. http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this something on my end? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/ https://reviews.llvm.org/D156363

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4539877 , @dblaikie wrote: > FWIW this sounds good to me (though given how wide the patch is, might be > worth waiting a few days to a week in case anyone else has thoughts). > > I only looked at a sample of the test

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

yaxunl accepted this revision. yaxunl added a comment. LGTM. It is good to be consistent with GCC. Most amdgpu and HIP tests fail due to missing -nogpuinc or -nogpulib. I can help update them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 accepted this revision. jhuber6 added a comment. I'd wager a lot of the tests that return non-zero aren't even intentional, so it's probably good to enforce this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. FWIW this sounds good to me (though given how wide the patch is, might be worth waiting a few days to a week in case anyone else has thoughts). I only looked at a sample of the test

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. @jhuber6 @yaxunl you may want to revise some AMDGPU related tests, e.g. `amdgcn-gz-options.cl`. Some `RUN: %clang` lines currently fail with `error: cannot find ROCm device library; provide its path via '--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to