[PATCH] D156482: [clang][CGExprConstant] handle FunctionToPointerDecay

2023-08-02 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1128 +case CK_NoOp: +case CK_NonAtomicToAtomic: return Visit(subExpr, destType); I think I'd prefer to continue treating an undecayed function as an "lvalue", to

[PATCH] D156482: [clang][CGExprConstant] handle FunctionToPointerDecay

2023-07-27 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Makes sense but I want @efriedma to look at as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156482/new/ https://reviews.llvm.org/D156482 ___ cfe-commits mailing list

[PATCH] D156482: [clang][CGExprConstant] handle FunctionToPointerDecay

2023-07-27 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 544909. nickdesaulniers added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156482/new/ https://reviews.llvm.org/D156482 Files: clang/lib/CodeGen/CGExprConstant.cpp Index:

[PATCH] D156482: [clang][CGExprConstant] handle FunctionToPointerDecay

2023-07-27 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the following code: void foo (void) {} void (*bar)(void) = foo; And the corresponding AST: