This revision was automatically updated to reflect the committed changes.
mboehme marked an inline comment as done.
Closed by commit rGf76f6674d822: [clang][dataflow] Use `Strict` accessors where
we werent using them yet. (authored by mboehme).
Repository:
rG LLVM Github Monorepo
CHANGES
ymandel accepted this revision.
ymandel added a comment.
SGTM
Comment at:
clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:545
+ (State.Env.createStorageLocation(*E));
+ State.Env.setStorageLocationStrict(*E, *Loc);
+}
mboehme marked 2 inline comments as done.
mboehme added inline comments.
Comment at:
clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:545
+ (State.Env.createStorageLocation(*E));
+ State.Env.setStorageLocationStrict(*E, *Loc);
+}
mboehme updated this revision to Diff 545611.
mboehme added a comment.
Use `Loc == nullptr` instead of `!Loc`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156672/new/
https://reviews.llvm.org/D156672
Files:
ymandel accepted this revision.
ymandel added inline comments.
This revision is now accepted and ready to land.
Comment at:
clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:542
+State.Env.getStorageLocationStrict(*E));
+if (!Loc) {
+ Loc
mboehme created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
mboehme requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This eliminates all uses of the deprecated
