[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

This revision was automatically updated to reflect the committed changes. Closed by commit rG501f92d34382: [llvm] Construct options prefixed name at compile-time (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG! LLVMOption has users in llvm/ clang/ lldb/ lld/ clang-tools-extra/ flang/. You'll need to check that all the affected users are migrated... Repository: rG LLVM Github Monorepo

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 updated this revision to Diff 548423. jansvoboda11 added a comment. Rebase, remove unnecessary changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm.org/D157029 Files:

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 updated this revision to Diff 547339. jansvoboda11 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm.org/D157029 Files: clang-tools-extra/clangd/CompileCommands.cpp

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 added a comment. In D157029#4561519 , @jansvoboda11 wrote: > In D157029#4561490 , @MaskRay wrote: > >> This increases the size of `Info` (static data size and static >> relocations). In return,

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 updated this revision to Diff 547316. jansvoboda11 added a comment. Remove `OptTable::Info::Name`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm.org/D157029 Files:

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 added a comment. In D157029#4561490 , @MaskRay wrote: > This increases the size of `Info` (static data size and static relocations). > In return, some dynamic relocations are saved. Is this a net win? If that's a concern, I can remove

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

MaskRay added a comment. This increases the size of `Info` (static data size and static relocations). In return, some dynamic relocations are saved. Is this a net win? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 added inline comments. Comment at: llvm/include/llvm/Option/Option.h:103 + StringLiteral getSpelling() const { +assert(Info && "Must have a valid info!"); benlangmuir wrote: > This could use a doc comment to differentiate it from other string