[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

2023-08-14 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. In D157297#4583802 , @lygstate wrote: > In D157297#4571572 , @pengfei wrote: > >> The description is not clear to me. You should describe the reason rather >> than phenomenon. >> >> My

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

2023-08-14 Thread Yonggang Luo via Phabricator via cfe-commits
lygstate added a comment. In D157297#4571572 , @pengfei wrote: > The description is not clear to me. You should describe the reason rather > than phenomenon. > > My understanding is double colon operator cannot resolve functions with > parentheses.

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

2023-08-09 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. Would we be better off creating proper function definitions - we already have similar duplicates for `_bextr_u64` (Intel) vs `__bextr_u64` (AMD) names that do this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

2023-08-08 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. The description is not clear to me. You should describe the reason rather than phenomenon. My understanding is double colon cannot operator cannot resolve functions with parentheses. But I didn't find enough proof in Google. It'd be more persuasive if you can find it

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

2023-08-07 Thread Yonggang Luo via Phabricator via cfe-commits
lygstate created this revision. Herald added a project: All. lygstate requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Error message: In file included from ../src/amd/addrlib/src/core/addrobject.h:21: