This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3dadc290b210: [clang] Add missing fields to DeprecatedAttr
and Unavailable json AST dump (authored by serge-sans-paille).
Repository:
rG LLVM
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157783/new/
https://reviews.llvm.org/D157783
___
cfe-commits mailing
serge-sans-paille marked an inline comment as done.
serge-sans-paille added a comment.
Review taken into account. Thanks for handling this batch of patches o/
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157783/new/
https://reviews.llvm.org/D157783
serge-sans-paille updated this revision to Diff 549929.
serge-sans-paille added a comment.
Only output extra fields if they are not empty
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157783/new/
https://reviews.llvm.org/D157783
Files:
clang/include/clang/AST/JSONNodeDumper.h
aaron.ballman added inline comments.
Comment at: clang/lib/AST/JSONNodeDumper.cpp:541-548
+void JSONNodeDumper::VisitDeprecatedAttr(const DeprecatedAttr *DA) {
+ JOS.attribute("message", DA->getMessage());
+ JOS.attribute("replacement", DA->getReplacement());
+}
+
+void
serge-sans-paille updated this revision to Diff 549645.
serge-sans-paille added a comment.
+ test case
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157783/new/
https://reviews.llvm.org/D157783
Files:
clang/include/clang/AST/JSONNodeDumper.h
clang/lib/AST/JSONNodeDumper.cpp
serge-sans-paille updated this revision to Diff 549644.
serge-sans-paille retitled this revision from "[clang] Add reason and
replacement fields to DeprecatedAttr json AST dump" to "[clang] Add rmissing
fields to DeprecatedAttr and UnavailableAttr json AST dump".
serge-sans-paille added a
