dang added a comment.
As per https://discourse.llvm.org/t/pull-request-migration-schedule/71595 we
should move this review to GitHub to make sure we don't lose track of it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157810/new/
ributzka added inline comments.
Comment at: clang/include/clang/ExtractAPI/API.h:141
+ unsigned Line, Col;
+ std::string Filename;
+
There is an opportunity for optimization by avoiding the allocation of separate
strings for each source location, especially
Arsenic updated this revision to Diff 553730.
Arsenic added a comment.
Fix minor typo is comments
- Move creation of DocComment in it's own seperate function
- Update the Underlying DataType used by RecordLocation
- Update the patch to account for new C++ APIRecords
Repository:
rG LLVM
dang added a comment.
LGTM
Comment at: clang/include/clang/ExtractAPI/API.h:137
-/// DocComment is a vector of RawComment::CommentLine.
+/// Slightly cut down version of PresumedLoc to suite the needs of
+/// ExtractAPI.
s/suite/suit
CHANGES SINCE LAST
Arsenic updated this revision to Diff 552794.
Arsenic added a comment.
- Create function to directly get DocComments from Decl
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157810/new/
https://reviews.llvm.org/D157810
Files:
clang/include/clang/ExtractAPI/API.h
dang added inline comments.
Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:182-189
DocComment Comment;
if (auto *RawComment =
- getDerivedExtractAPIVisitor().fetchRawCommentForDecl(Decl))
-Comment =
Arsenic updated this revision to Diff 549691.
Arsenic added a comment.
Fix minor typo in code comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157810/new/
https://reviews.llvm.org/D157810
Files:
clang/include/clang/ExtractAPI/API.h
Arsenic created this revision.
Arsenic added a reviewer: dang.
Herald added a reviewer: ributzka.
Herald added a project: All.
Arsenic requested review of this revision.
Herald added subscribers: cfe-commits, wangpc.
Herald added a project: clang.
Create and use extractapi::RecordLocation instead
