davide closed this revision.
davide added a comment.
Close, this went in a while ago.
Repository:
rL LLVM
http://reviews.llvm.org/D15791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
andrew added a comment.
Can someone commit with the FIXME comment? I'm unable to do it myself.
Repository:
rL LLVM
http://reviews.llvm.org/D15791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
davide accepted this revision.
davide added a reviewer: davide.
davide added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Driver/Tools.cpp:941
@@ -940,3 +940,3 @@
- // The kext linker doesn't know how to deal with movw/movt.
- if
davide added a comment.
In http://reviews.llvm.org/D15791#317172, @dim wrote:
> @davide, any idea whether lld will be able to handle movt correctly? If so,
> we might want to make this dependent on `-fuse-ld=bfd` or `-fuse-ld=lld` ?
lld/AArch64 can't still handle that properly, so I'd rather
emaste added a comment.
> @davide, any idea whether lld will be able to handle movt correctly? If so,
> we might want to make this dependent on -fuse-ld=bfd or -fuse-ld=lld ?
I'm sure lld will handle everything we need eventually (if it does not
already), but I'm not sure it's reasonable to
dim added a comment.
In http://reviews.llvm.org/D15791#317175, @emaste wrote:
> > @davide, any idea whether lld will be able to handle movt correctly? If so,
> > we might want to make this dependent on -fuse-ld=bfd or -fuse-ld=lld ?
>
>
> I'm sure lld will handle everything we need eventually
