iana requested changes to this revision.
iana added a comment.
This revision now requires changes to proceed.
I was talking to Ben about this one a little today since I ended up needing to
make the same `-isystem`/`-I` -> `-internal-isystem` switch in some of the unit
tests in D159064
vsapsai added a comment.
Running the tests locally fails with
lib/clang/18/include/inttypes.h:21:15: fatal error: 'inttypes.h' file not
found
21 | #include_next
| ^~~~
Is it something wrong with my local configuration?
Also want to study the previous
benlangmuir updated this revision to Diff 550474.
benlangmuir added a reviewer: vsapsai.
benlangmuir added a comment.
Add missing test updates: tests using the `Inputs/System/usr/include` should be
using `-internal-isystem` to get the correct search path order with respect to
the resource dir.
iana added a subscriber: vsapsai.
iana added a comment.
Herald added a subscriber: ormris.
Can you add @vsapsai to the reviewers please? He was looking at this one a year
or two ago.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158021/new/
benlangmuir created this revision.
benlangmuir added reviewers: iana, jansvoboda11.
Herald added a project: All.
benlangmuir requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Like the other enumerated builtin headers, inttypes.h can be
