[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fd01d75a863: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan marked an inline comment as done. zyounan added a comment. Thanks again for the review! Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:28 + +// expected-error@#1 {{no member named 'value' in 'is_convertible'}} + erichkeane wrote: > So I

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 555277. zyounan marked an inline comment as done. zyounan added a comment. Address one last nit comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files:

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Clean up the test layout a little as a part of the commit, otherwise, LGTM! Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:28 + +// expected-error@#1

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 554919. zyounan added a comment. Rebase to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added a comment. Thanks for the review! Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:26 +// Consume remaining notes/errors. +// expected-note@* 0+{{}} +// expected-error@* 0+{{}} erichkeane wrote: > Please don't do this, actually

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 554914. zyounan marked an inline comment as done. zyounan added a comment. Expand diagnostics in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files:

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

erichkeane added a comment. Hi, sorry for the delay in reviewing, I'm just coming back from an extended vacation. This looks alright, except for the test. Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:26 +// Consume remaining notes/errors. +//

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added a comment. Gently ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 551728. zyounan added a comment. Rebase and Remove the stray status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 551726. zyounan added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:9079 +auto *IDC = TC->getImmediatelyDeclaredConstraint(); +assert(IDC && "ImmediatelyDeclaredConstraint can't be null here."); +ExprResult Constraint = SubstExpr(IDC, MLTAL);

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 550713. zyounan added a comment. Adapt to D157554 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files:

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 550683. zyounan added a comment. Rebase and format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/include/clang/AST/ExprConcepts.h

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan created this revision. zyounan added reviewers: saar.raz, erichkeane, ilya-biryukov, aaron.ballman. Herald added a subscriber: kadircet. Herald added a project: All. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're